diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2003-02-01 22:09:41 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2003-02-01 22:09:41 +0000 |
| commit | d77c6396bbd84429c3bdf773c76c7b25c23734a2 (patch) | |
| tree | 0a467f432b02267380c84efcc3f5b70d1e416b1b /src | |
| parent | af30b9561841ccbeb1adb7fe7e8d15635a29211d (diff) | |
Remove restriction that cast functions cannot be volatile. This
restriction was debatable to begin with, but it has now become obvious
that it breaks forward-porting of user-defined types; contrib/lo being
the most salient example.
Diffstat (limited to 'src')
| -rw-r--r-- | src/backend/commands/functioncmds.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c index 2e660d7f61a..0af5ebd0765 100644 --- a/src/backend/commands/functioncmds.c +++ b/src/backend/commands/functioncmds.c @@ -9,7 +9,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.24 2002/11/01 19:19:58 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.24.2.1 2003/02/01 22:09:41 tgl Exp $ * * DESCRIPTION * These routines take the parse tree and pick out the @@ -745,8 +745,15 @@ CreateCast(CreateCastStmt *stmt) elog(ERROR, "argument of cast function must match source data type"); if (procstruct->prorettype != targettypeid) elog(ERROR, "return data type of cast function must match target data type"); + /* + * Restricting the volatility of a cast function may or may not be + * a good idea in the abstract, but it definitely breaks many old + * user-defined types. Disable this check --- tgl 2/1/03 + */ +#ifdef NOT_USED if (procstruct->provolatile == PROVOLATILE_VOLATILE) elog(ERROR, "cast function must not be volatile"); +#endif if (procstruct->proisagg) elog(ERROR, "cast function must not be an aggregate function"); if (procstruct->proretset) |