diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-09-30 16:24:56 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-09-30 16:24:56 -0400 |
| commit | e5baf8c27e6cc2c83cc81b620e75ad3d571d51c4 (patch) | |
| tree | 5853b7e9cd6ccf4fd1e818a2f19da2c808234929 /src | |
| parent | 26b877d280eeb23d57b507a1ebb14f240d317eb8 (diff) | |
Fix detection of the result type of strerror_r().
The method we've traditionally used, of redeclaring strerror_r() to
see if the compiler complains of inconsistent declarations, turns out
not to work reliably because some compilers only report a warning,
not an error. Amazingly, this has gone undetected for years, even
though it certainly breaks our detection of whether strerror_r
succeeded.
Let's instead test whether the compiler will take the result of
strerror_r() as a switch() argument. It's possible this won't
work universally either, but it's the best idea I could come up with
on the spur of the moment.
Back-patch of commit 751f532b9. Buildfarm results indicate that only
icc-on-Linux actually has an issue here; perhaps the lack of field
reports indicates that people don't build PG for production that way.
Discussion: https://postgr.es/m/10877.1537993279@sss.pgh.pa.us
Diffstat (limited to 'src')
| -rw-r--r-- | src/include/pg_config.h.in | 2 | ||||
| -rw-r--r-- | src/include/pg_config.h.win32 | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index bfe2c43ec56..2038c3cd599 100644 --- a/src/include/pg_config.h.in +++ b/src/include/pg_config.h.in @@ -779,7 +779,7 @@ /* Define to 1 if you have the ANSI C header files. */ #undef STDC_HEADERS -/* Define to 1 if strerror_r() returns a int. */ +/* Define to 1 if strerror_r() returns int. */ #undef STRERROR_R_INT /* Define to 1 if your <sys/time.h> declares `struct tm'. */ diff --git a/src/include/pg_config.h.win32 b/src/include/pg_config.h.win32 index 78ca7647ba7..5bcaf5b3c12 100644 --- a/src/include/pg_config.h.win32 +++ b/src/include/pg_config.h.win32 @@ -621,7 +621,7 @@ /* Define to 1 if you have the ANSI C header files. */ #define STDC_HEADERS 1 -/* Define to 1 if strerror_r() returns a int. */ +/* Define to 1 if strerror_r() returns int. */ /* #undef STRERROR_R_INT */ /* Define to 1 if your <sys/time.h> declares `struct tm'. */ |