diff options
| author | Andres Freund <andres@anarazel.de> | 2024-04-07 19:00:11 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2024-04-07 19:09:07 -0700 |
| commit | eabf98e949e3a655494a32ceb8d146117cce0505 (patch) | |
| tree | 7f1e0b3f2f1147cae7939a8fd4254d064c3aa4cf /src | |
| parent | 5fe7bcc6766be52bf5958ac660af92da482ba0e3 (diff) | |
simplehash: Free collisions array in SH_STAT
While SH_STAT() is only used for debugging, the allocated array can be large,
and therefore should be freed.
It's unclear why coverity started warning now.
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Reported-by: Coverity
Discussion: https://postgr.es/m/3005248.1712538233@sss.pgh.pa.us
Backpatch: 12-
Diffstat (limited to 'src')
| -rw-r--r-- | src/include/lib/simplehash.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/include/lib/simplehash.h b/src/include/lib/simplehash.h index b4573187c63..5373dac3445 100644 --- a/src/include/lib/simplehash.h +++ b/src/include/lib/simplehash.h @@ -977,6 +977,9 @@ SH_STAT(SH_TYPE * tb) max_collisions = curcoll; } + /* large enough to be worth freeing, even if just used for debugging */ + pfree(collisions); + if (tb->members > 0) { fillfactor = tb->members / ((double) tb->size); |