summaryrefslogtreecommitdiff
path: root/src/backend/optimizer/geqo/geqo_eval.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/backend/optimizer/geqo/geqo_eval.c')
-rw-r--r--src/backend/optimizer/geqo/geqo_eval.c15
1 files changed, 5 insertions, 10 deletions
diff --git a/src/backend/optimizer/geqo/geqo_eval.c b/src/backend/optimizer/geqo/geqo_eval.c
index 71d7f0f399c..00dbffa4ea3 100644
--- a/src/backend/optimizer/geqo/geqo_eval.c
+++ b/src/backend/optimizer/geqo/geqo_eval.c
@@ -5,7 +5,7 @@
*
* Copyright (c) 1994, Regents of the University of California
*
- * $Id: geqo_eval.c,v 1.30 1999/02/14 04:56:45 momjian Exp $
+ * $Id: geqo_eval.c,v 1.31 1999/02/15 02:04:58 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -337,24 +337,21 @@ new_join_tlist(List *tlist,
{
int resdomno = first_resdomno - 1;
TargetEntry *xtl = NULL;
- List *temp_node = NIL;
List *t_list = NIL;
List *i = NIL;
List *join_list = NIL;
bool in_final_tlist = false;
-
foreach(i, tlist)
{
xtl = lfirst(i);
+ /* XXX surely this is wrong? join_list is never changed? tgl 2/99 */
in_final_tlist = (join_list == NIL);
if (in_final_tlist)
{
resdomno += 1;
- temp_node = lcons(create_tl_element(get_expr(xtl),
- resdomno),
- NIL);
- t_list = nconc(t_list, temp_node);
+ t_list = lappend(t_list,
+ create_tl_element(get_expr(xtl), resdomno));
}
}
@@ -590,7 +587,6 @@ static List *
geqo_final_join_rels(List *join_rel_list)
{
List *xrel = NIL;
- List *temp = NIL;
List *t_list = NIL;
/*
@@ -615,8 +611,7 @@ geqo_final_join_rels(List *join_rel_list)
}
if (final)
{
- temp = lcons(rel, NIL);
- t_list = nconc(t_list, temp);
+ t_list = lappend(t_list, rel);
}
}