diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-01-25 09:33:41 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-01-25 09:35:00 -0500 |
| commit | aebeb4790c750dc808c1c5afb3cb435116244e36 (patch) | |
| tree | 532565a943fe186d599d075570c523331bf3c0fc /src/backend/parser/parse_agg.c | |
| parent | 87ecf2d14fa236e894267ef5e702ff08b8965f9d (diff) | |
Remove vestigial resolveUnknown arguments from transformSortClause etc.
There's really no situation where we don't want these unknown-to-text
conversions to happen. The alternative is failure anyway, and the one
caller that was passing "false" did so only because it expected the
case could not arise. Might as well simplify the code.
Discussion: https://postgr.es/m/CAH2L28uwwbL9HUM-WR=hromW1Cvamkn7O-g8fPY2m=_7muJ0oA@mail.gmail.com
Diffstat (limited to 'src/backend/parser/parse_agg.c')
| -rw-r--r-- | src/backend/parser/parse_agg.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/backend/parser/parse_agg.c b/src/backend/parser/parse_agg.c index 7be7fe96892..efe1c371efc 100644 --- a/src/backend/parser/parse_agg.c +++ b/src/backend/parser/parse_agg.c @@ -155,8 +155,7 @@ transformAggregateCall(ParseState *pstate, Aggref *agg, tlist = lappend(tlist, tle); torder = addTargetToSortList(pstate, tle, - torder, tlist, sortby, - true /* fix unknowns */ ); + torder, tlist, sortby); } /* Never any DISTINCT in an ordered-set agg */ @@ -196,7 +195,6 @@ transformAggregateCall(ParseState *pstate, Aggref *agg, aggorder, &tlist, EXPR_KIND_ORDER_BY, - true /* fix unknowns */ , true /* force SQL99 rules */ ); /* |